[ovs-dev] [PATCH] Documentation: Also define install-man-rst when Sphinx is not available.

Ben Pfaff blp at ovn.org
Mon Sep 25 18:27:14 UTC 2017


"make sandbox" wants to install the ReST manpages, but it failed when
Sphinx wasn't available.  This fixes the problem.

Fixes: 986311be550e ("ovs-sandbox: Install .rst manpages into the sandbox as well.")
Reported-by: Justin Pettit <jpettit at ovn.org>
Signed-off-by: Ben Pfaff <blp at ovn.org>
---
 Documentation/automake.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/automake.mk b/Documentation/automake.mk
index 24fe63d87140..6f38912f264b 100644
--- a/Documentation/automake.mk
+++ b/Documentation/automake.mk
@@ -178,8 +178,8 @@ extract_stem_and_section = \
 	eval "mandir=\$$man$${section}dir"; \
 	test -n "$$mandir" || { echo "unknown directory for manpage section $$section"; continue; }
 
-if HAVE_SPHINX
 INSTALL_DATA_LOCAL += install-man-rst
+if HAVE_SPHINX
 install-man-rst: docs-check
 	@$(set_mandirs); \
 	for rst in $(RST_MANPAGES); do \
@@ -189,6 +189,9 @@ install-man-rst: docs-check
 	    echo " $(INSTALL_DATA) $(SPHINXBUILDDIR)/man/$$stem.$$section '$(DESTDIR)'\"$$mandir/$$stem.$$section\""; \
 	    $(INSTALL_DATA) $(SPHINXBUILDDIR)/man/$$stem.$$section '$(DESTDIR)'"$$mandir/$$stem.$$section"; \
 	done
+else
+install-man-rst:
+	@:
 endif
 
 UNINSTALL_LOCAL += uninstall-man-rst
-- 
2.10.2



More information about the dev mailing list