[ovs-dev] [PATCH] Windows: Fix broken build caused by a bad file extension

aserdean at ovn.org aserdean at ovn.org
Mon Apr 2 07:21:18 UTC 2018


> -----Mesaj original-----
> De la: ovs-dev-bounces at openvswitch.org <ovs-dev-
> bounces at openvswitch.org> În numele Ben Pfaff
> Trimis: Saturday, March 31, 2018 10:47 PM
> Către: Alin Gabriel Serdean <aserdean at ovn.org>
> Cc: ovs-dev at openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH] Windows: Fix broken build caused by a bad
> file extension
> 
> On Tue, Mar 27, 2018 at 08:29:49PM +0300, Alin Gabriel Serdean wrote:
> > The compiler (cl) complains:
> > `ovsdb/ovsdb-server.c(689) : fatal error C1083:
> >     Cannot open include file: 'ovsdb/_server.ovsschema.inc':
> >        No such file or directory`
> > (https://ci.appveyor.com/project/blp/ovs/build/1.0.4079#L2586)
> >
> > Generated compiler objects have the extension `.obj` on Windows.
> >
> > This patch switches to `$(OBJEXT)` instead, so the schema will be
> generated.
> >
> > Signed-off-by: Alin Gabriel Serdean aserdean at ovn.org
> 
> Oops!  Thanks for the fix.
> 
> Acked-by: Ben Pfaff <blp at ovn.org>
No worries, it happens. Thanks for the review, I applied it on master!

Alin.



More information about the dev mailing list