[ovs-dev] [PATCH] v2, python-windows: Fix unicode python tests on Windows

aserdean at ovn.org aserdean at ovn.org
Mon Apr 2 07:57:39 UTC 2018


> -----Mesaj original-----
> De la: ovs-dev-bounces at openvswitch.org <ovs-dev-
> bounces at openvswitch.org> În numele Ben Pfaff
> Trimis: Saturday, March 31, 2018 10:46 PM
> Către: Alin Gabriel Serdean <aserdean at ovn.org>
> Cc: dev at openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH] v2, python-windows: Fix unicode python
> tests on Windows
> 
> On Wed, Mar 28, 2018 at 12:11:18PM +0300, Alin Gabriel Serdean wrote:
> > This patch changes the default filesystem encodings to the values used
> > before python3.6 to ensure compatibility with older versions.
> >
> > Signed-off-by: Alin Gabriel Serdean <aserdean at ovn.org>
> > Co-authored-by: Alin Balutoiu <abalutoiu at cloudbasesolutions.com>
> > ---
> > v2: update commit message
> 
> I don't really understand this change, but if it fixes a problem in the
tests
> then I'm all in favor of it.
> 
> If it is not difficult, then I would suggest adding a little more
information to
> the commit message, such as an example of what goes wrong without it.
> 
> Acked-by: Ben Pfaff <blp at ovn.org>
> _______________________________________________
I'll drop this change and improve the commit message in the next revision.
Thanks for the review!

Alin.





More information about the dev mailing list