[ovs-dev] [PATCH] netlink-socket: don't check for namespace id under Windows

aserdean at ovn.org aserdean at ovn.org
Tue Apr 3 12:09:29 UTC 2018


> -----Mesaj original-----
> De la: ovs-dev-bounces at openvswitch.org <ovs-dev-
> bounces at openvswitch.org> În numele Flavio Leitner
> Trimis: Tuesday, April 3, 2018 2:48 AM
> Către: Aaron Conole <aconole at redhat.com>
> Cc: dev at openvswitch.org; Alin Gabriel Serdean <aserdean at ovn.org>
> Subiect: Re: [ovs-dev] [PATCH] netlink-socket: don't check for namespace id
> under Windows
> 
> On Mon, Apr 02, 2018 at 06:31:05PM -0400, Aaron Conole wrote:
> > The namespace identification is only relevant under Linux systems.
> > Even if it weren't, this code is targetted to Linux, and the Windows
> > control message structure doesn't look the same.
> >
> > When building on Windows platform, the following error occurs:
> >
> >   lib/netlink-socket.c(750) : error C2039: 'Control' : is not a member of
> 'msghdr'
> >
> > Fixes: a86bd14 ("netlink: provide network namespace id from a msg.")
> > Cc: Flavio Leitner <fbl at redhat.com>
> > Signed-off-by: Aaron Conole <aconole at redhat.com>
> > ---
> 
> Acked-by: Flavio Leitner <fbl at redhat.com>
> 
> Thanks Aaron!
> fbl
> 
Thanks for trying to fix this Aaron and Flavio!
I sent a patch yesterday on the same topic and Ben saw we missed the initialization part: https://mail.openvswitch.org/pipermail/ovs-dev/2018-April/345677.html 
Again, really thanks for trying to fix it 😊

Alin.



More information about the dev mailing list