[ovs-dev] [PATCH] ovsdb: omit_alert should implicitely turn off tracking.

Ben Pfaff blp at ovn.org
Tue Apr 3 18:15:34 UTC 2018


On Sun, Apr 01, 2018 at 08:32:02PM -0700, Han Zhou wrote:
> On Sun, Apr 1, 2018 at 4:26 PM, Ben Pfaff <blp at ovn.org> wrote:
> >
> > On Fri, Mar 16, 2018 at 07:02:43PM -0700, Han Zhou wrote:
> > > OVSDB_IDL_TRACK is not valid without OVSDB_IDL_ALERT, so it should
> > > be turned off as well in ovsdb_idl_omit_alert().
> > >
> > > Signed-off-by: Han Zhou <hzhou8 at ebay.com>
> >
> > Thanks for the patch.  It looks correct to me.
> >
> > Before I apply it, does this fix any bugs (performance-wise or
> > otherwise) or is it just something you noticed while reading code?  If
> > it fixes something, then we should note it in the commit message.
> >
> > Thanks,
> >
> > Ben.
> 
> Hi Ben, I didn't see any bug yet, but it will be useful for the
> ovn-controller incremental processing patch I am working on. Since this is
> pretty small, I submitted separately.

Thanks.

I would like to apply it but it appears to need a rebase.

Thanks,

Ben.


More information about the dev mailing list