[ovs-dev] [PATCH] ofp-actions: Correct execution of encap/decap actions in action set

Ben Pfaff blp at ovn.org
Tue Apr 3 18:36:19 UTC 2018


On Mon, Mar 26, 2018 at 09:36:27AM +0200, Jan Scheurich wrote:
> The actions encap, decap and dec_nsh_ttl were wrongly flagged as set_field
> actions in ofpact_is_set_or_move_action(). This caused them to be executed
> twice in the action set or a group bucket, once explicitly in
> ofpacts_execute_action_set() and once again as part of the list of
> set_field or move actions.
> 
> Fixes: f839892a ("OF support and translation of generic encap and decap")
> Fixes: 491e05c2 ("nsh: add dec_nsh_ttl action")
> 
> Signed-off-by: Jan Scheurich <jan.scheurich at ericsson.com>
> 
> ---
> 
> The fix should be backported to OVS 2.9 and OVS 2.8 (without the case
> for OFPACT_DEC_NSH_TTL introduced in 2.9).

Thanks, I applied this to master and backported to branch-2.9 and
branch-2.8.

I want to encourage you to add a test that uses one or both of these
actions in an action set, so that we get some test coverage.

Thanks,

Ben.


More information about the dev mailing list