[ovs-dev] [PATCH] checkpatch: Fix mis-flagging of division operators as lacking whitespace.

Ben Pfaff blp at ovn.org
Tue Apr 3 21:13:57 UTC 2018


On Tue, Apr 03, 2018 at 04:19:38PM -0400, Aaron Conole wrote:
> Ben Pfaff <blp at ovn.org> writes:
> 
> > The regular expression here would flag any slash that wasn't adjacent to
> > an asterisk as missing whitespace.  This fixes the problem.
> >
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> > ---
> 
> Tested-by: Aaron Conole <aconole at redhat.com>

Thanks, applied to master.

> I noticed that one of the raft patches flagged (which I hadn't noticed
> when I tested the original change - sorry) for this, and this patch
> clears that up.
> 
> I'm actually seeing some of 'line lacks whitespace around operator'
> being flagged (for instance, '--' looks to cause a flag, and probably
> should get some kind of treatment in the future).

Yeah, we can keep refining this forever.


More information about the dev mailing list