[ovs-dev] [PATCH v2] ovsdb: omit_alert should implicitely turn off tracking.

Han Zhou zhouhan at gmail.com
Wed Apr 4 17:24:24 UTC 2018


OVSDB_IDL_TRACK is not valid without OVSDB_IDL_ALERT, so it should
be turned off as well in ovsdb_idl_omit_alert().

Signed-off-by: Han Zhou <hzhou8 at ebay.com>
---

Notes:
    v1->v2: rebase

 lib/ovsdb-idl.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
index eb28988..11794a8 100644
--- a/lib/ovsdb-idl.c
+++ b/lib/ovsdb-idl.c
@@ -1512,7 +1512,7 @@ ovsdb_idl_send_cond_change(struct ovsdb_idl *idl)
     }
 }
 
-/* Turns off OVSDB_IDL_ALERT for 'column' in 'db'.
+/* Turns off OVSDB_IDL_ALERT and OVSDB_IDL_TRACK for 'column' in 'db'.
  *
  * This function should be called between ovsdb_idl_create() and the first call
  * to ovsdb_idl_run().
@@ -1521,10 +1521,10 @@ static void
 ovsdb_idl_db_omit_alert(struct ovsdb_idl_db *db,
                         const struct ovsdb_idl_column *column)
 {
-    *ovsdb_idl_db_get_mode(db, column) &= ~OVSDB_IDL_ALERT;
+    *ovsdb_idl_db_get_mode(db, column) &= ~(OVSDB_IDL_ALERT | OVSDB_IDL_TRACK);
 }
 
-/* Turns off OVSDB_IDL_ALERT for 'column' in 'idl'.
+/* Turns off OVSDB_IDL_ALERT and OVSDB_IDL_TRACK for 'column' in 'idl'.
  *
  * This function should be called between ovsdb_idl_create() and the first call
  * to ovsdb_idl_run().
-- 
2.1.0



More information about the dev mailing list