[ovs-dev] [PATCH 4/5] userspace: add gre sequence number support.

Ben Pfaff blp at ovn.org
Thu Apr 5 00:34:41 UTC 2018

On Fri, Mar 09, 2018 at 01:02:24PM -0800, William Tu wrote:
> The patch adds support for gre sequence number.
> Default is disable.  When enable with 'options:seq=true',
> the outgoing gre packet will have its sequence number
> incremented by one.
> Signed-off-by: William Tu <u9012063 at gmail.com>

Thank you work working on ERSPAN support.

"sparse" says:

    ../lib/netdev-native-tnl.c:458:29: error: cast from 'char *' to 'ovs_be32 *' (aka 'unsigned int *') increases required alignment from 1 to 4 [-Werror,-Wcast-align]

I think that it is probably right that this is a bit risky, because OVS
cannot always ensure that packet data is 32-bit aligned.  You can use
ovs_16aligned_be32 and get_16aligned_be32, or even get_unaligned_be32,

More information about the dev mailing list