[ovs-dev] [PATCH 1/2] OVN: add icmp6{} action support

Ben Pfaff blp at ovn.org
Fri Apr 6 17:38:12 UTC 2018


On Fri, Apr 06, 2018 at 07:05:32PM +0200, Lorenzo Bianconi wrote:
> icmp6 action is used to replace the IPv6 packet been processed with
> an ICMPv6 packet initialized based on incoming IPv6 one.
> Ethernet and IPv6 fields not listed are not changed:
> - ip.proto = 58 (ICMPv6)
> - ip.ttl = 255
> - icmp6.type = 1 (destination unreachable)
> - icmp6.code = 1 (communication administratively prohibited)
> Prerequisite: ip6
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi at redhat.com>

Thank you for implementing this.

It looks like ACTION_OPCODE_ICMP4 and ACTION_OPCODE_ICMP6 actually have
exactly the same implementation.  Maybe ACTION_OPCODE_ICMP4 could be
renamed ACTION_OPCODE_ICMP and ACTION_OPCODE_ICMP6 just omitted.

Thanks,

Ben.


More information about the dev mailing list