[ovs-dev] [PATCH 1/2] dpdk docs: Drop qemu-kvm for qemu-system-x86_64.
tiago.lam at intel.com
Thu Apr 12 07:26:29 UTC 2018
On 11/04/2018 14:53, Aaron Conole wrote:
> Tiago Lam <tiago.lam at intel.com> writes:
>> When explaining on how to add vhost-user ports to a guest, using
>> libvirt, point to the qemu-system-x86_64 binary by default, instead of
>> using qemu-kvm. The latter has been made obsolete and dropped from a
>> number of distributions (although it is still available on Fedora).
>> This has been verified on both a Fedora 27 image and a Ubuntu 16.04 LTS
>> Signed-off-by: Tiago Lam <tiago.lam at intel.com>
>> Documentation/topics/dpdk/vhost-user.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/Documentation/topics/dpdk/vhost-user.rst b/Documentation/topics/dpdk/vhost-user.rst
>> index ca8a328..74bab78 100644
>> --- a/Documentation/topics/dpdk/vhost-user.rst
>> +++ b/Documentation/topics/dpdk/vhost-user.rst
>> @@ -401,7 +401,7 @@ Sample XML
>> - <emulator>/usr/bin/qemu-kvm</emulator>
> Looks like this isn't even a proper path on some systems. For example,
> RHEL7 it's:
> So it's doubly wrong.
>> + <emulator>/usr/bin/qemu-system-x86_64</emulator>
>> <disk type='file' device='disk'>
>> <driver name='qemu' type='qcow2' cache='none'/>
>> <source file='/root/CentOS7_x86_64.qcow2'/>
> On the other hand, on my RHEL7.4 system, I don't have
> qemu-system-x86_64, but I do have qemu-kvm.
That's unfortunate. I would have thought that Fedora derivatives, at
least, would have it (I've checked on Fedora 27). But my main reason to
stick with `/usr/bin/qemu-system-x86_64` is because it is used in
another part of the guide already , so this keeps it consistent.
> I do like cookbook examples, but it seems that sometimes the care and
> feeding of these sections gets cumbersome. Maybe there's a way of
> including just the xml portions we need for a vhost-enabled libvirt xml
> Just a thought.
I agree on that. But if I'm understanding correctly then the user would
need to find a template configuration himself (and hopefully that would
come pointing to the right binary on his system). But maybe that's
something we're comfortable with.
> Acked-by: Aaron Conole <aconole at redhat.com>
More information about the dev