[ovs-dev] [PATCH] netdev-dpdk: fix MAC address in port addr example
O Mahony, Billy
billy.o.mahony at intel.com
Thu Apr 12 11:54:14 UTC 2018
Apologies. It wasn't clear that you had actually hands on experience of the issue.
> -----Original Message-----
> From: ovs-dev-bounces at openvswitch.org [mailto:ovs-dev-
> bounces at openvswitch.org] On Behalf Of O Mahony, Billy
> Sent: Wednesday, April 11, 2018 10:32 AM
> To: Marcelo Ricardo Leitner <marcelo.leitner at gmail.com>;
> dev at openvswitch.org
> Cc: slavash at mellanox.com
> Subject: Re: [ovs-dev] [PATCH] netdev-dpdk: fix MAC address in port addr
> Hi Marcelo,
> I haven't used the specific cards referred to in the surrounding documentation
> but I don't think the 'mac' address format is a typo.
> The notation is specific to some vendor NICs that have several Ethernet devices
> sharing a single PCI bus:device.function address. In that case the PCI address
> alone cannot distinguish the Ethernet device to be uses ofr the dpdk port.
> "Some NICs (i.e. Mellanox ConnectX-3) have only one PCI address associated
> with multiple ports. Using a PCI device like above won't work. Instead, below
> usage is suggested::"
> > -----Original Message-----
> > From: ovs-dev-bounces at openvswitch.org [mailto:ovs-dev-
> > bounces at openvswitch.org] On Behalf Of Marcelo Ricardo Leitner
> > Sent: Monday, April 9, 2018 6:21 PM
> > To: dev at openvswitch.org
> > Cc: marcelo.leitner at gmail.com; slavash at mellanox.com
> > Subject: [ovs-dev] [PATCH] netdev-dpdk: fix MAC address in port addr
> > example
> > The MAC address is always 6-bytes long, never 7. The extra :01 and :02
> > doesn't belong in there as it doesn't mean selecting one port or another.
> > Instead, use an incrementing MAC address, which is what usually
> > happens on such cards.
> > See-also: http://www.dpdk.org/ml/archives/dev/2018-April/094976.html
> > Fixes: 5e7588186839 ("netdev-dpdk: fix port addition for ports sharing
> > same PCI
> > id")
> > Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner at gmail.com>
> > ---
> > Documentation/howto/dpdk.rst | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> > diff --git a/Documentation/howto/dpdk.rst
> > b/Documentation/howto/dpdk.rst index
> > e07afa6f99cf903 100644
> > --- a/Documentation/howto/dpdk.rst
> > +++ b/Documentation/howto/dpdk.rst
> > @@ -53,9 +53,9 @@ with multiple ports. Using a PCI device like above
> > won't work. Instead, below usage is suggested::
> > $ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \
> > - options:dpdk-devargs="class=eth,mac=00:11:22:33:44:55:01"
> > + options:dpdk-devargs="class=eth,mac=00:11:22:33:44:55"
> > $ ovs-vsctl add-port br0 dpdk-p1 -- set Interface dpdk-p1 type=dpdk \
> > - options:dpdk-devargs="class=eth,mac=00:11:22:33:44:55:02"
> > + options:dpdk-devargs="class=eth,mac=00:11:22:33:44:56"
> > Note: such syntax won't support hotplug. The hotplug is supposed to
> > work with future DPDK release, v18.05.
> > --
> > 2.14.3
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> dev mailing list
> dev at openvswitch.org
More information about the dev