[ovs-dev] [PATCH v8 2/6] dpif-netdev: retrieve flow directly from the flow mark

[Ben Pfaff]

On Sun, Apr 15, 2018 at 12:40:28PM +0000, Shahaf Shuler wrote:
> Thursday, April 12, 2018 4:39 PM, Stokes, Ian:
> > Subject: RE: [PATCH v8 2/6] dpif-netdev: retrieve flow directly from the flow
> > mark
> > > > > +
> > > > > +    if (!(nw_frag & FLOW_NW_FRAG_LATER) && nw_proto ==
> > > > IPPROTO_TCP &&
> > > > > +        size >= TCP_HEADER_LEN) {
> > > > > +        const struct tcp_header *tcp = data;
> > > > > +
> > > > > +        return TCP_FLAGS_BE32(tcp->tcp_ctl);
> > > >
> > > > Will cause compilation failure with sparse when compiling without DPDK.
> > > >
> > > > lib/flow.c:1070:16: error: incorrect type in return expression
> > > > (different base
> > > > types)
> > > > lib/flow.c:1070:16:    expected unsigned short
> > > > lib/flow.c:1070:16:    got restricted ovs_be32 [usertype] <noident>
> > >
> > > Thanks,
> > >
> > > Is there a way for me to re-run travis build so I can verify it is fixed?
> > 
> > Sure, Travis can link to a github account. The OVS test doc has steps you can
> > follow to set it up:
> > 
> > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdoc
> > s.openvswitch.org%2Fen%2Flatest%2Ftopics%2Ftesting%2F%23continuous-
> > integration-with-travis-
> > ci&data=02%7C01%7Cshahafs%40mellanox.com%7C4ab1d89f766f4969a93d0
> > 8d5a07aea0c%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636591
> > 372144565253&sdata=GnJlyU0Sob%2BQGEODZcfSo%2BOwu0R0YgESLqVd4Ks
> > IQyQ%3D&reserved=0
> > 
> 
> Am getting this error[1] when enabling the sparse compiler. 
> 
> I thought it should be included in the Travis builder. 
> 
> [1]
> https://travis-ci.org/shahafsh/ovs/jobs/366766006

The build enables sparse already, see .travis/linux-build.sh.  You don't
need it as a separate compiler.