[ovs-dev] [PATCH] ovsdb-tool: Skip monitor argument on Windows

Alin Gabriel Serdean aserdean at ovn.org
Mon Apr 16 20:15:59 UTC 2018



> On 16 Apr 2018, at 23:11, Ben Pfaff <blp at ovn.org> wrote:
> 
> On Mon, Apr 16, 2018 at 04:29:27PM +0300, Alin Gabriel Serdean wrote:
>> The daemon argument '--monitor' does not exist on Windows so the process will
>> complain:
>> +2018-04-16T13:10:24Z|00001|getopt_long|WARN|unknown option -- monitor
>> +ovsdb-server: Failed to read from child (The pipe has been ended.
>> +)
>> Skip the argument when running the test under Windows.
>> 
>> Signed-off-by: Alin Gabriel Serdean <aserdean at ovn.org>
> 
> Thanks for fixing the problem.
> 
> I think that we should remove --monitor unconditionally here, not just
> on Windows.  At most, it will cover up some genuine bug that the tests
> should find.
> 
> Thanks,
> 
> Ben.

Sounds good. I’ll send another revision.

Alin.


More information about the dev mailing list