[ovs-dev] [PATCH] rhel: Fix literal dollar sign usage in systemd service files

Eelco Chaudron echaudro at redhat.com
Tue Apr 17 09:18:26 UTC 2018


On 16/04/18 17:15, Timothy Redaelli wrote:
> Currently (at least on RHEL 7.5) openvswitch fails to start (with DPDK
> enabled) as non-root, since chown fails and "/dev/hugepages" group is not
> changed.
>
> Commit tested on Fedora 28 and RHEL 7.5, both as root as non-root user.
>
>  From man 5 systemd.service:
>
>    To pass a literal dollar sign, use "$$". Variables whose value is not known
>    at expansion time are treated as empty strings. Note that the first argument
>    (i.e. the program to execute) may not be a variable.
>
> CC: Aaron Conole <aconole at redhat.com>
> Fixes: 4299145c1095 ("rhel: don't drop capabilities when running as root")
> Signed-off-by: Timothy Redaelli <tredaelli at redhat.com>
<SNIP>

Changes look good to me!

Acked-by: Eelco Chaudron <echaudro at redhat.com>


More information about the dev mailing list