[ovs-dev] [PATCH v2] rhel: user/group openvswitch does not exist

Aaron Conole aconole at redhat.com
Wed Apr 18 15:54:57 UTC 2018


Markos Chandras <mchandras at suse.de> writes:

> Hi Aaron,
>
> On 18/04/18 15:51, Aaron Conole wrote:
>> v2:
>>  * Removed the requires(post) lines
>>  * Removed 'exit 0'
>
> I realize that I was the one suggested to drop 'exit 0', but right at
> the bottom of
> https://fedoraproject.org/wiki/Packaging:UsersAndGroups#Dynamic_allocation
>
> it seems that 'exit 0' may do more good than bad. Having said that, this
> could make it easy to miss useradd/usermod/etc failure so I am not too
> sure if we want to do that :)

I can certainly re-add it.  The rationale section calls adding the 'exit
0' "...suboptimal but has less potential for system wide breakage..."

I can go either way.  Maybe Alan or Timothy have opinions?


More information about the dev mailing list