[ovs-dev] [PATCH v2] python: Tighten the check if we need encoding

Ben Pfaff blp at ovn.org
Thu Apr 19 16:28:16 UTC 2018


On Thu, Apr 19, 2018 at 11:33:21AM +0200, Jakub Sitnicki wrote:
> Check if we are dealing with a Unicode string that needs
> encoding for both Python 2 & 3.
> 
> Also, do the encoding the same way for Python 2 & 3 and avoid using
> negation to make the code simpler.
> 
> v1 -> v2: Rewrite the check for Unicode string to avoid flake8 warnings.
> 
> Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
> ---
> 
> Ben,
> 
> Thanks for pointing out the flake8 warnings. It was poorly done.
> 
> This version should read much better, and be free of warnings.

Thanks, I applied this version to master.


More information about the dev mailing list