[ovs-dev] [PATCH] ofproto-dpif-upcall: Only call ovsrcu_postpone() on active actions

Ben Pfaff blp at ovn.org
Thu Apr 19 16:30:32 UTC 2018

On Thu, Apr 19, 2018 at 01:24:06PM +0200, Eelco Chaudron wrote:
> Currently, ovsrcu_postpone() is called even with a NULL argument,
> i.e. when there is no data to be freed. This is causing additional
> overhead because work is scheduled for the urcu thread. This change
> avoids adding the postpone callback if no work needs to be done.
> This especially helps for the OVS-DPDK case where the PMD threads
> might no longer have to do a write() due to the latch_set(), and thus
> saving a syscall.
> Signed-off-by: Eelco Chaudron <echaudro at redhat.com>

Wow, good catch!

Thanks, I applied this to master.

More information about the dev mailing list