[ovs-dev] [PATCH] ofproto: Allow bundle idle timeout to be configured.

Flavio Leitner fbl at sysclose.org
Thu Apr 19 17:14:55 UTC 2018


On Fri, Apr 13, 2018 at 10:48:09AM -0700, Ben Pfaff wrote:
> On Fri, Apr 13, 2018 at 01:45:30PM -0300, Flavio Leitner wrote:
> > In some cases 10 seconds might be too much time and in
> > other cases it might be too little.
> > 
> > The OpenFlow spec mandates that it should wait at least one
> > second, so enforce that as the minimum acceptable value.
> > 
> > Signed-off-by: Flavio Leitner <fbl at sysclose.org>
> 
> Thanks for the patch.
> 
> I don't think that this will set the idle timeout back to the default if
> the setting is removed.  It's better if there's that behavior.

Agreed.

> What do you think of this incremental?  I have not tested it but it is
> meant to behave that way.  Also it avoids integer overflow.

I sent out a v2 including your fix and another test case:
https://mail.openvswitch.org/pipermail/ovs-dev/2018-April/346319.html

Thanks Ben,
fbl



More information about the dev mailing list