[ovs-dev] [patch v1] ovn-northd: Fix parsing of load balance keys.

Mark Michelson mmichels at redhat.com
Tue Apr 24 13:32:59 UTC 2018


Thanks Darrell.

Acked-by: Mark Michelson <mmichels at redhat.com>

On 04/24/2018 05:35 AM, Darrell Ball wrote:
> The OVN load balance tests are failing in both kernel and userspace DP.
> The problem is due to bad parsing of the load balance keys because of
> using the wrong default port mode in the call to inet_parse_active().
> 
> With this fix, the tests are now passing again.
> 
> system-ovn
> 
> 100: ovn -- load-balancing                           ok
> 101: ovn -- load-balancing - same subnet.            ok
> 102: ovn -- load balancing in gateway router         ok
> 103: ovn -- multiple gateway routers, load-balancing ok
> 104: ovn -- load balancing in router with gateway router port ok
> 
> Signed-off-by: Darrell Ball <dlu998 at gmail.com>
> ---
>   ovn/northd/ovn-northd.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
> index ce472a5..6ffebde 100644
> --- a/ovn/northd/ovn-northd.c
> +++ b/ovn/northd/ovn-northd.c
> @@ -2942,7 +2942,7 @@ ip_address_and_port_from_lb_key(const char *key, char **ip_address,
>                                   uint16_t *port, int *addr_family)
>   {
>       struct sockaddr_storage ss;
> -    if (!inet_parse_active(key, -1, &ss)) {
> +    if (!inet_parse_active(key, 0, &ss)) {
>           static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 1);
>           VLOG_WARN_RL(&rl, "bad ip address or port for load balancer key %s",
>                        key);
> 



More information about the dev mailing list