[ovs-dev] [PATCH v3] ovs-ofctl: Fixed the "snoop" command of ovs-ofctl

Ben Pfaff blp at ovn.org
Wed Apr 25 19:47:04 UTC 2018

On Fri, Apr 20, 2018 at 03:28:38PM -0700, Ashish Varma wrote:
> In case where "use_names" is set (e.g. in an interactive session) to show
> the port and table names when ovs-ofctl is run with snoop command,
> ovs-ofctl would get stuck in an endless loop inside "table_iterator_next"
> function's while loop checking for "while (ti->send_xid != recv_xid)".
> This would happening because the "vconn" to "<bridge>.snoop" socket would
> not respond to TABLE_FEATURES_REQUEST sent by ovs-ofctl.
> This commit disables showing port or table names in the snoop command.
> Signed-off-by: Ashish Varma <ashishvarma.ovs at gmail.com>
> ---
> v2-v3
> Updated the comment in the code to explain why 'use_names' is set to 0
> for snoop command.

Thanks, I applied this to master.  I updated the style of the comment to
match our usual coding style requirements.



More information about the dev mailing list