[ovs-dev] [PATCH] odp-util: Remove unnecessary TOS ECN bits rewrite for tunnels

Simon Horman simon.horman at netronome.com
Thu Apr 26 12:50:12 UTC 2018


Thanks Jianbo,

On 26 April 2018 at 07:54, Jianbo Liu <jianbol at mellanox.com> wrote:

> For tunnels, TOS ECN bits are never wildcard for the reason that they
> are always inherited. OVS will create a rewrite action if we add rule
> to modify other IP headers. But it also adds an extra ECN rewrite for
> the action because of this ECN un-wildcarding.
>
> It seems no error because the ECN bits to be changed are same in this
> case. But as rule can't be offloaded to hardware, the unnecssary ECN
> rewrite should be removed.
>
> Signed-off-by: Jianbo Liu <jianbol at mellanox.com>
> Reviewed-by: Paul Blakey <paulb at mellanox.com>
> Reviewed-by: Roi Dayan <roid at mellanox.com>
>

I'd like to take a little time to test this one.


More information about the dev mailing list