[ovs-dev] 答复: [PATCH] dpif-netdev:Delete port check in do_add_port

Linhaifeng haifeng.lin at huawei.com
Sat Apr 28 02:24:33 UTC 2018


Ping...

-----邮件原件-----
发件人: Linhaifeng 
发送时间: 2018年4月26日 15:13
收件人: dev at openvswitch.org
抄送: Linhaifeng <haifeng.lin at huawei.com>
主题: [PATCH] dpif-netdev:Delete port check in do_add_port

It is not need check port exist in do_add_port
because it had check in port_add.

Change-Id: Ie66206b40e305cef5f5b20af765c3128ccec6782
Signed-off-by: Haifeng Lin <haifeng.lin at huawei.com>
---
 lib/dpif-netdev.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index be31fd0..f7976b1 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -1568,11 +1568,6 @@ do_add_port(struct dp_netdev *dp, const char *devname, const char *type,
     struct dp_netdev_port *port;
     int error;
 
-    /* Reject devices already in 'dp'. */
-    if (!get_port_by_name(dp, devname, &port)) {
-        return EEXIST;
-    }
-
     error = port_create(devname, type, port_no, &port);
     if (error) {
         return error;
-- 
1.8.5.2.msysgit.0




More information about the dev mailing list