[ovs-dev] [PATCH] odp-util: Remove unnecessary TOS ECN bits rewrite for tunnels

Ben Pfaff blp at ovn.org
Sat Apr 28 18:52:09 UTC 2018


On Thu, Apr 26, 2018 at 05:54:48AM +0000, Jianbo Liu wrote:
> For tunnels, TOS ECN bits are never wildcard for the reason that they
> are always inherited. OVS will create a rewrite action if we add rule
> to modify other IP headers. But it also adds an extra ECN rewrite for
> the action because of this ECN un-wildcarding.
> 
> It seems no error because the ECN bits to be changed are same in this
> case. But as rule can't be offloaded to hardware, the unnecssary ECN
> rewrite should be removed.
> 
> Signed-off-by: Jianbo Liu <jianbol at mellanox.com>
> Reviewed-by: Paul Blakey <paulb at mellanox.com>
> Reviewed-by: Roi Dayan <roid at mellanox.com>

Thanks for working on improving OVS.

Please add {} around conditional statements, according to OVS style.

This isn't really a review because I didn't consider anything beyond
style.

Thanks,

Ben.


More information about the dev mailing list