[ovs-dev] [PATCH] odp-util: Remove unnecessary TOS ECN bits rewrite for tunnels

Simon Horman simon.horman at netronome.com
Mon Apr 30 08:53:14 UTC 2018

On 26 April 2018 at 14:50, Simon Horman <simon.horman at netronome.com> wrote:

> Thanks Jianbo,
> On 26 April 2018 at 07:54, Jianbo Liu <jianbol at mellanox.com> wrote:
>> For tunnels, TOS ECN bits are never wildcard for the reason that they
>> are always inherited. OVS will create a rewrite action if we add rule
>> to modify other IP headers. But it also adds an extra ECN rewrite for
>> the action because of this ECN un-wildcarding.
>> It seems no error because the ECN bits to be changed are same in this
>> case. But as rule can't be offloaded to hardware, the unnecssary ECN
>> rewrite should be removed.
>> Signed-off-by: Jianbo Liu <jianbol at mellanox.com>
>> Reviewed-by: Paul Blakey <paulb at mellanox.com>
>> Reviewed-by: Roi Dayan <roid at mellanox.com>
> I'd like to take a little time to test this one.

Hi Jinbao,

thanks again for your patch. We have tested this patch and from a
functional point of view it looks good to me.
Could you post a v2 which addresses the style concerns raised separately by


More information about the dev mailing list