[ovs-dev] [PATCH] ovn: Fix typos in "ovn -- Address Set generation..." test.

Jakub Sitnicki jkbs at redhat.com
Wed Aug 1 08:35:31 UTC 2018


On Tue, 31 Jul 2018 12:45:41 -0700
Ben Pfaff <blp at ovn.org> wrote:

> These caused the test to fail.
> 
> CC: Jakub Sitnicki <jkbs at redhat.com>
> Fixes: 984c7d5ea8fe ("ovn-northd: Propagate dynamic addresses to port group address sets.")
> Signed-off-by: Ben Pfaff <blp at ovn.org>
> ---
>  tests/ovn.at | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/ovn.at b/tests/ovn.at
> index 17c740aa2352..1b25b6e4d6b9 100644
> --- a/tests/ovn.at
> +++ b/tests/ovn.at
> @@ -10361,10 +10361,10 @@ ovn-nbctl set Logical_Switch ls1 \
>  
>  dnl Check if updated address got propagated to the port group address sets
>  AT_CHECK([ovn-sbctl get Address_Set pg1_ip4 addresses],
> -         [0], [[["10.11.0.2", "10.2.0.2"]]
> +         [0], [[["10.1.0.2", "10.2.0.2"]]
>  ])
>  AT_CHECK([ovn-sbctl get Address_Set pg1_ip6 addresses],
> -         [0], [[["2001:db8:11::ff:fe00:1", "2001:db8:2::ff:fe00:2"]]
> +         [0], [[["2001:db8:1::ff:fe00:1", "2001:db8:2::ff:fe00:2"]]
>  ])
>  
>  AT_CLEANUP

Oops, these weren't typos. It fails because the series depends on
Mark's IPAM changes:

https://patchwork.ozlabs.org/patch/947155/

Without it the dynamic addresses don't get updated when subnet/prefix
for the switch changes.

FWIW, I've mentioned it in the cover letter:

https://mail.openvswitch.org/pipermail/ovs-dev/2018-July/350143.html

-Jakub


More information about the dev mailing list