[ovs-dev] [PATCH 10/11] dpctl: Implement dpctl commands for conntrack per zone limit

[Yi-Hung Wei]

On Wed, Aug 1, 2018 at 10:37 PM, Darrell Ball <dlu998 at gmail.com> wrote:
> On Wed, Aug 1, 2018 at 3:46 PM, Yi-Hung Wei <yihung.wei at gmail.com> wrote:
>
> Do these commands need a ‘zone’ keyword
>
> eg) ct-set-zone-limits
>
>>
>> $ ovs-appctl dpctl/ct-set-limits default=10 zone=0,limit=5 zone=1,limit=3

I think I am fine either way. I can change ct-set-zone-limits to
ct-set-limits in later version.

>
> I wonder if it makes sense to write
>
> ‘zone=default,limit=10’
>
> so that ‘default’ is treated like any zone?
That makes sense, and I think it does simplify the syntax.  Will make
this change in v3.

>>
>> $ ovs-appctl dpct/ct-del-limits zone=0
>
>
>
> I wonder if we set zone limit to zero (unlimited), it could be like deleting
> a zone limit.
>
> $ ovs-appctl dpctl/ct-set-limits zone=1,limit=0

The default limit may change from time to time, it is not necessarily
to be zero (unlimited).

On the other hand, we may set limit to 'default', such as having
commands like $ ovs-appctl dpctl/ct-set-limits zone=1,limit=default
zone=2,limit=default zone=3,limit=default

But it  seems to be easier to have syntax like $ ovs-appctl
dpctl/ct-del-lmits zone=1,2,3

Therefore, I prefer to keep the ct-del-limits command as is.

Thanks,

-Yi-Hung