[ovs-dev] [PATCH] utilities: Install ovs-tcp{dump, undump} also when only Python3 is enabled

[Timothy Redaelli]

On Fri, 3 Aug 2018 16:57:48 -0700
Ben Pfaff <blp at ovn.org> wrote:

> On Fri, Aug 03, 2018 at 08:28:08PM +0200, Timothy Redaelli wrote:
> > Since commit 793bdb6c0500 ("ovs-tcpdump: Fix incompatibilities with
> > python3") and commit 227abb77d3d1 ("ovs-tcpundump: Fix
> > incompatibilities with python3") ovs-tcpdump and ovs-tcpdump works
> > with Python3 as well.
> > 
> > This commit allows ovs-tcpdump and ovs-tcpundump to be installed
> > also when only Python3 is enabled.
> > 
> > Signed-off-by: Timothy Redaelli <tredaelli at redhat.com>  
> 
> Often, when new programs start getting installed, we need updates to
> the rpm spec files.  Do we need an update in this case?

Usually yes, but in this case it's no needed since, currently, the spec
files doesn't allow to build OVS with only Python3 enabled and so
ovs-tcp{,un}dump were always installed.

In rhel/openvswitch-fedora.spec.in and rhel/openvswitch.spec.you can
see that ovs-tcp{,un}dump are already present in %files section without
any if.

I'll probably send a patch to openvswitch-fedora.spec.in in order to
add a "--with only_python3" option to build with only Python3 enabled.

This option will eventually proposed as the default option for the
distributions that uses Python3 by default (like Fedora 32, first half
of 2020).