[ovs-dev] [patch v2] dpctl: Simplify dpctl_flush_conntrack.

[Darrell Ball]

thanks for checking that; I thought the system tests has full coverage for these aspects.
The proposed change would cause inappropriate log entries.
Anyways, I rethought the approach to make it more general and sent a V3.


On 8/3/18, 5:36 PM, "ovs-dev-bounces at openvswitch.org on behalf of Ben Pfaff" <ovs-dev-bounces at openvswitch.org on behalf of blp at ovn.org> wrote:

    On Thu, Aug 02, 2018 at 08:20:58PM -0700, Darrell Ball wrote:
    > The function dpctl_flush_conntrack() and other such functions with
    > multiple optional arguments can be simplified by introducing a new
    > function to check whether a valid datapath name is supplied as an
    > argument to the functions.
    > 
    > opt_dpif_open() can also make use of this new function to allow it
    > to handle callers with multiple optional arguments.
    > 
    > Signed-off-by: Darrell Ball <dlu998 at gmail.com>
    
    Thanks for working on making the OVS code easier to understand.
    
    When I applied this patch, I get two test failures:
    
    1195: ofproto-dpif - ovs-appctl dpif/get-flow         FAILED (ofproto-dpif.at:7838)
    1196: ofproto-dpif - ovs-appctl dpif/get-flow - pmd   FAILED (ofproto-dpif.at:7839)
    
    Can you take a look?
    
    Thanks,
    
    Ben


    _______________________________________________
    dev mailing list
    dev at openvswitch.org
    https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fmailman%2Flistinfo%2Fovs-dev&amp;data=02%7C01%7Cdball%40vmware.com%7Ca777b208e07c4fa14fb308d5f9a25c24%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C1%7C0%7C636689398104481064&amp;sdata=L8oeG8pqYM6UpPwOPCz%2Fd1%2BnTcTyr%2Ff6T6b2qTkkzSA%3D&amp;reserved=0