[ovs-dev] [patch v2] stream-ssl: Tweak recent change to fix travis builds.

Ben Pfaff blp at ovn.org
Mon Aug 6 22:07:55 UTC 2018


On Mon, Aug 06, 2018 at 02:54:12PM -0700, Darrell Ball wrote:
> 10 of the travis builds are failing such as
> TESTSUITE=1 KERNEL=3.16.54 for gcc and clang.
> 
> Fixes: ab16d2c2871b ("stream-ssl: Don't enable new TLS versions by default")
> CC: Timothy Redaelli <tredaelli at redhat.com>
> Signed-off-by: Darrell Ball <dlu998 at gmail.com>
> ---
>  lib/stream-ssl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/stream-ssl.c b/lib/stream-ssl.c
> index f3d623c..0d5e0de 100644
> --- a/lib/stream-ssl.c
> +++ b/lib/stream-ssl.c
> @@ -1188,7 +1188,7 @@ stream_ssl_set_protocols(const char *arg)
>      }
>  
>      /* Start with all the flags off and turn them on as requested. */
> -    long protocol_flags = SSL_OP_NO_SSL_MASK;
> +    long protocol_flags = 0;
>  
>      char *s = xstrdup(arg);
>      char *save_ptr = NULL;

I believe that this defeats the purpose of the original patch.
How about this:
https://patchwork.ozlabs.org/patch/954255/


More information about the dev mailing list