[ovs-dev] [PATCH v3 8/9] tests: Reorder logging args for ovn-sbctl in a subshell.

Ilya Maximets i.maximets at samsung.com
Wed Aug 8 12:35:39 UTC 2018


'--log-file' should go after '-v' arguments to avoid unwanted
'opened log file' messages.
Execution is in a subshell and not covered by aliases.

Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Acked-by: Aaron Conole <aconole at redhat.com>
---
 tests/ovsdb-cluster.at | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tests/ovsdb-cluster.at b/tests/ovsdb-cluster.at
index 01650df..a85a945 100644
--- a/tests/ovsdb-cluster.at
+++ b/tests/ovsdb-cluster.at
@@ -136,7 +136,11 @@ ovsdb|WARN|schema: changed 2 columns in 'OVN_Southbound' database from ephemeral
     for i in $(seq 0 $(expr $n1 - 1) ); do
         (for j in $(seq $n2); do
              : > $i-$j.running
-             run_as "ovn-sbctl($i-$j)" ovn-sbctl "-vPATTERN:console:ovn-sbctl($i-$j)|%D{%H:%M:%S}|%05N|%c|%p|%m" --log-file=$i-$j.log -vfile -vsyslog:off -vtimeval:off --timeout=120 --no-leader-only add SB_Global . external_ids $i-$j=$i-$j
+             run_as "ovn-sbctl($i-$j)" \
+                ovn-sbctl "-vPATTERN:console:ovn-sbctl($i-$j)|%D{%H:%M:%S}|%05N|%c|%p|%m" \
+                    -vfile -vsyslog:off -vtimeval:off --log-file=$i-$j.log \
+                    --timeout=120 --no-leader-only \
+                    add SB_Global . external_ids $i-$j=$i-$j
              status=$?
              if test $status != 0; then
                  echo "$i-$j exited with status $status" > $i-$j:$status
-- 
2.7.4



More information about the dev mailing list