[ovs-dev] [PATCH] checkpatch: Improve accuracy and specificity of sign-off checking.

Aaron Conole aconole at redhat.com
Fri Aug 10 19:13:18 UTC 2018


Aaron Conole <aconole at redhat.com> writes:

> Ben Pfaff <blp at ovn.org> writes:
>
>> This also makes a start at a testsuite for checkpatch.
>>
>> CC: Aaron Conole <aconole at redhat.com>
>> Signed-off-by: Ben Pfaff <blp at ovn.org>
>> ---
>
> I think it's close, but I still get this sort of error:
>
> 03:07:46 aconole {ipsec_selinux} ~/git/ovs$ ./utilities/checkpatch.py -1
> == Checking fa10857dafcc ("checkpatch: Improve accuracy and
> specificity of sign-off checking.") ==
> ERROR: Committer None needs to sign off.
> Lines checked: 268, Warnings: 0, Errors: 1
>

Actually, it was correct - I did forget to sign off.  However, even when
I do, I see:

WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Aaron Conole <aconole at redhat.com>


More information about the dev mailing list