[ovs-dev] [PATCH] ofp-group: Fix memory leak in error cases parsing group requests.
Ben Pfaff
blp at ovn.org
Fri Aug 10 19:42:31 UTC 2018
Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9424#c4
Signed-off-by: Ben Pfaff <blp at ovn.org>
---
lib/ofp-group.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/ofp-group.c b/lib/ofp-group.c
index f6e5242f5244..62cab725efb5 100644
--- a/lib/ofp-group.c
+++ b/lib/ofp-group.c
@@ -1748,7 +1748,7 @@ ofputil_decode_ofp15_group_desc_reply(struct ofputil_group_desc *gd,
msg, gd->type, OFPGC15_ADD, &gd->props,
length - sizeof *ogds - bucket_list_len);
if (error) {
- ofputil_bucket_list_destroy(&gd->buckets);
+ ofputil_uninit_group_desc(gd);
}
return error;
}
@@ -2173,7 +2173,7 @@ ofputil_pull_ofp15_group_mod(struct ofpbuf *msg, enum ofp_version ofp_version,
error = parse_ofp15_group_properties(msg, gm->type, gm->command,
&gm->props, msg->size);
if (error) {
- ofputil_bucket_list_destroy(&gm->buckets);
+ ofputil_uninit_group_mod(gm);
}
return error;
}
--
2.16.1
More information about the dev
mailing list