[ovs-dev] [PATCH v5 01/20] ovsdb-idl.c: Remove a misleading comment for change tracking.

Han Zhou zhouhan at gmail.com
Mon Aug 13 17:48:00 UTC 2018


The comment was added when the feature was introduced but what it
described is not what is implemented, probably because of revisions
after code reviews.

Signed-off-by: Han Zhou <hzhou8 at ebay.com>
---
 lib/ovsdb-idl.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
index 40c29cb..b0ebe8c 100644
--- a/lib/ovsdb-idl.c
+++ b/lib/ovsdb-idl.c
@@ -2834,9 +2834,7 @@ ovsdb_idl_row_clear_arcs(struct ovsdb_idl_row *row, bool destroy_dsts)
     struct ovsdb_idl_arc *arc, *next;
 
     /* Delete all forward arcs.  If 'destroy_dsts', destroy any orphaned rows
-     * that this causes to be unreferenced, if tracking is not enabled.
-     * If tracking is enabled, orphaned nodes are removed from hmap but not
-     * freed.
+     * that this causes to be unreferenced.
      */
     LIST_FOR_EACH_SAFE (arc, next, src_node, &row->src_arcs) {
         ovs_list_remove(&arc->dst_node);
-- 
2.1.0



More information about the dev mailing list