[ovs-dev] [PATCH] ofproto-dpif-upcall: Fix for flow limit issue in revalidator

Ben Pfaff blp at ovn.org
Wed Aug 15 20:10:46 UTC 2018


On Fri, Aug 03, 2018 at 06:04:23AM +0530, Vishal Deep Ajmera wrote:
> When the revalidator thread takes a long time to dump data path
> flows (e.g. due to busy CPU), it reduces the maximum limit for
> new flows that can be added. This results in more upcalls for
> packets which do not find data path flows and temporarily reduces
> overall throughput. When the situation improves and the revalidator
> gets enough CPU cycles, it should increase the flow limit allowing
> more flows to get inserted.
> 
> Currently the flow limit does not increase if the existing number of
> flows is less than 2000 and does not allow any new flows due to
> incorrect condition check. This results in a permanent drop in
> performance in OVS with no automatic recovery.
> 
> This patch fixes the conditional check for increasing flow limit.
> 
> Signed-off-by: Vishal Deep Ajmera <vishal.deep.ajmera at ericsson.com>

Thanks, applied to master.


More information about the dev mailing list