[ovs-dev] [PATCH v3] netdev: Retry getting interfaces on inconsistent dumps from kernel

Ben Pfaff blp at ovn.org
Wed Aug 15 20:40:05 UTC 2018


On Mon, Aug 13, 2018 at 05:39:07PM -0700, Ben Pfaff wrote:
> On Mon, Aug 13, 2018 at 02:07:45PM +0200, Daniel Alvarez wrote:
> > This patch in glibc [0] is fixing a bug where we may be getting
> > inconsistent dumps from the kernel when listing interfaces due to
> > a race condition.
> > 
> > This could happen if we try to retrieve them while interfaces are
> > being added/removed from the system at the same time.
> > For systems running against old glibc versions, this patch is retrying
> > the operation up to 3 times and then proceeding by logging a
> > warning.
> > 
> > Note that 3 times should be enough to not delay the operation much
> > and since it's unlikely that we hit the race condition 3 times in
> > a row. Still, if this happened, this patch is not changing the
> > current behavior.
> > 
> > [0] https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c1f86a33ca32e26a9d6e29fc961e5ecb5e2e5eb4
> > 
> > Signed-off-by: Daniel Alvarez <dalvarez at redhat.com>
> > Co-authored-by: Jiri Benc <jbenc at redhat.com>
> 
> Thanks for the patch.
> 
> As a co-author, Jiri also needs to sign off.
> 
> Acked-by: Ben Pfaff <blp at ovn.org>

I see that Jiri signed off earlier and it just didn't get propagated.

Thanks, I applied this to master and branch-2.10.


More information about the dev mailing list