[ovs-dev] [PATCH 1/2] dpif: Don't pass in '*meter_id' to meter_set commands.

Justin Pettit jpettit at ovn.org
Thu Aug 16 17:31:24 UTC 2018


> On Aug 14, 2018, at 1:55 PM, Ben Pfaff <blp at ovn.org> wrote:
> 
> On Wed, Aug 08, 2018 at 05:35:21PM -0700, Justin Pettit wrote:
>> The original intent of the API appears to be that the underlying DPIF
>> implementaion would choose a local meter id.  However, neither of the
>> existing datapath meter implementations (userspace or Linux) implemented
>> that; they expected a valid meter id to be passed in, otherwise they
>> returned an error.  This commit follows the existing implementations and
>> makes the API somewhat cleaner.
>> 
>> Signed-off-by: Justin Pettit <jpettit at ovn.org>
> 
> For the series (please consider the comments on patch 2):
> Acked-by: Ben Pfaff <blp at ovn.org>

Thanks!  I pushed the changes with your suggestion to master and branch-2.10.

--Justin




More information about the dev mailing list