[ovs-dev] [patch v8 4/9] conntrack: Reword conntrack_execute() description.

[Darrell Ball]

On Tue, Jul 31, 2018 at 10:37 AM, Justin Pettit <jpettit at ovn.org> wrote:

>
> > On Jul 16, 2018, at 7:39 PM, Darrell Ball <dlu998 at gmail.com> wrote:
> >
> > Use 'must' instead of 'should'.
> >
> > Signed-off-by: Darrell Ball <dlu998 at gmail.com>
> > ---
> > lib/conntrack.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/conntrack.c b/lib/conntrack.c
> > index 682feb9..3f50fc8 100644
> > --- a/lib/conntrack.c
> > +++ b/lib/conntrack.c
> > @@ -1294,7 +1294,7 @@ process_one(struct conntrack *ct, struct dp_packet
> *pkt,
> > }
> >
> > /* Sends the packets in '*pkt_batch' through the connection tracker
> 'ct'.  All
> > - * the packets should have the same 'dl_type' (IPv4 or IPv6) and should
> have
> > + * the packets must have the same 'dl_type' (IPv4 or IPv6) and should
> have
> >  * the l3 and and l4 offset properly set.
>
> I assume that the l3 and l4 must also be properly set.  I removed the
> duplicate "and" and used a capital "L" since a lowercase can look like a
> "1" with some fonts.




> /* Sends the packets in '*pkt_batch' through the connection tracker
>  * 'ct'.  All the packets must have the same 'dl_type' (IPv4 or IPv6)
>  * and have the L3 and L4 offset properly set.
>

Thanks for fixing these legacy comments Justin.



>
> Does that look reasonable to you?
>
> --Justin
>
>
>