[ovs-dev] [PATCH] dpif-netlink: Prevent abort in probe_broken_meters().

Ben Pfaff blp at ovn.org
Fri Aug 17 20:08:51 UTC 2018


On Fri, Aug 17, 2018 at 01:05:48PM -0700, Justin Pettit wrote:
> Commit 92d0d515d ("dpif-netlink: Probe for broken Linux meter
> implementations.") introduced a deadlock on the 'once' structure
> declared in probe_broken_meters() with the following callstack:
> 
>         probe_broken_meters()
>         probe_broken_meters__()
>         dpif_netlink_meter_set()
>         probe_broken_meters()
> 
> This commit introduce a modified version of dpif_netlink_meter_set()
> that sets a meter without calling the probe.
> 
> Reported-by: Numan Siddique <nusiddiq at redhat.com>
> Signed-off-by: Justin Pettit <jpettit at ovn.org>

I didn't test this; I assume you did.

Acked-by: Ben Pfaff <blp at ovn.org>


More information about the dev mailing list