[ovs-dev] [PATCH 1/2] windows: Add set_deatch function to daemon-windows.c

[Guru Shetty]

On Tue, 21 Aug 2018 at 11:19, Ben Pfaff <blp at ovn.org> wrote:

> On Tue, Aug 21, 2018 at 05:57:47PM +0300, Alin Gabriel Serdean wrote:
> > The daemon-windows file is missing a `set_detach` routine, so add it.
> >
> > This will be useful in the long run.
> >
> > Signed-off-by: Alin Gabriel Serdean <aserdean at ovn.org>
>
> Thank you for maintaining the Windows port.  We could not do it without
> you.
>
> There is a misspelling in the subject: s/deatch/detach/.
>
> I don't entirely understand the implications of this patch.  Guru, I
> believe that you were involved in the design of --service.  Do you have
> any comments?
>
I do not see a need for this. But I don't see a harm either. I suppose Alin
forsees a need for this in the future. I am ok with a merge.


>
> For myself:
> Acked-by: Ben Pfaff <blp at ovn.org>
>
> Thanks,
>
> Ben.
>