[ovs-dev] RX Mirroing issue with Decap in vxlan case

[Simon Horman]

Hi Ben,

given the history of the offload code where output to more than one port is
a relatively new feature it does seem entirely possible to me that there is
a bug in the offload code as described below.

I will look into getting this investigated and if necessary fixed.

On Tue, Aug 21, 2018 at 02:13:50PM -0700, Ben Pfaff wrote:
> Ah.  In that case, probably I'm not the right person to handle this.
> 
> Simon, does this make sense to you?
> 
> On Tue, Aug 21, 2018 at 08:17:23PM +0000, Limaye, Namrata wrote:
> > I haven’t tested it with openvswitch kernel and code that is issue is in tc.c so I am guessing it is only hw offload.
> > 
> > Thanks
> > Namrata
> > 
> > > On Aug 21, 2018, at 12:37 PM, Ben Pfaff <blp at ovn.org> wrote:
> > > 
> > > Is this problem only for hardware offload?
> > > 
> > >> On Tue, Aug 21, 2018 at 06:26:03PM +0000, Limaye, Namrata wrote:
> > >> Sorry missed the release part -
> > >> 
> > >> Release action is added first in this function before any other action is processed which is used in decap case in our solution. 
> > >> 
> > >> 'nl_msg_put_flower_acts'
> > >> 
> > >> if (flower->tunnel.tunnel) {
> > >>            act_offset = nl_msg_start_nested(request, act_index++);
> > >>            nl_msg_put_act_tunnel_key_release(request);
> > >>            nl_msg_end_nested(request, act_offset);
> > >>        }
> > >> 
> > >> The ENCAP action is added fine in order within ' case TC_ACT_ENCAP:'
> > >> 
> > >> Thanks
> > >> Namrata
> > >> 
> > >> 
> > >> -----Original Message-----
> > >> From: Limaye, Namrata 
> > >> Sent: Tuesday, August 21, 2018 11:22 AM
> > >> To: 'Ben Pfaff' <blp at ovn.org>
> > >> Cc: bugs at openvswitch.org; ovs-dev at openvswitch.org; Saha, Gargi <gargi.saha at intel.com>; Choi, James <james.choi at intel.com>
> > >> Subject: RE: [ovs-dev] RX Mirroing issue with Decap in vxlan case
> > >> 
> > >> Hi Ben,
> > >> 
> > >> This is the configuration -
> > >> 
> > >> ovs-vsctl -- --id=@p get port vxlan0 -- --id=@eth0.128 get Port eth0.128 -- --id=@eth0.129 get Port eth0.129 -- --id=@m create Mirror name=mirror1 select-src-port=@eth0.128, at p output-port=@eth0.129 -- set Bridge br0 mirrors=@m
> > >> 
> > >> Thanks
> > >> Namrata
> > >> 
> > >> -----Original Message-----
> > >> From: Ben Pfaff [mailto:blp at ovn.org]
> > >> Sent: Tuesday, August 21, 2018 11:15 AM
> > >> To: Limaye, Namrata <namrata.limaye at intel.com>
> > >> Cc: bugs at openvswitch.org; ovs-dev at openvswitch.org; Saha, Gargi <gargi.saha at intel.com>; Choi, James <james.choi at intel.com>
> > >> Subject: Re: [ovs-dev] RX Mirroing issue with Decap in vxlan case
> > >> 
> > >>> On Fri, Aug 17, 2018 at 06:55:39PM +0000, Limaye, Namrata wrote:
> > >>> 
> > >>> Hi,
> > >>> 
> > >>> I am facing an issue with Decap in RX Mirroring case (select_src_port) 
> > >>> for Vxlan. With the following config –
> > >>> 
> > >>> ovs-vsctl -- --id=@p get port vxlan0 -- --id=@eth0.128<mailto:--id=@eth0.128> get Port eth0.128 -- --id=@eth0.129<mailto:--id=@eth0.129> get Port eth0.129 -- --id=@m create Mirror name=mirror1 select-src-port=@eth0.128, at p<mailto:select-src-port=@eth0.128, at p> output-port=@eth0.129<mailto:output-port=@eth0.129> -- set Bridge br0 mirrors=@m”.
> > >>> 
> > >>> The order of action and ports is wrong. This is the order –
> > >>> 
> > >>> 
> > >>> 1.       Release action
> > >>> 
> > >>> 2.       Mirror port (Non vxlan)
> > >>> 
> > >>> 3.       Output port (VXlan)
> > >>> 
> > >>> For actions to be applied in the right order – the order should be –
> > >>> 
> > >>> 1.       Mirror port (non vxlan)
> > >>> 
> > >>> 2.       Release action
> > >>> 
> > >>> 3.       Output port (VXlan)
> > >> 
> > >> What's a release action?
> > >> 
> > >> Can you provide your configuration without corrupting it with <mailto:...>?
> > >> 
> > >> Thanks,
> > >> 
> > >> Ben.