[ovs-dev] [PATCH] ofproto-dpif-trace: Make -generate send packets to controller again.

Ben Pfaff blp at ovn.org
Mon Aug 27 16:40:21 UTC 2018


On Fri, Aug 24, 2018 at 01:30:24PM -0700, Justin Pettit wrote:
> 
> > On Aug 24, 2018, at 12:25 PM, Ben Pfaff <blp at ovn.org> wrote:
> > 
> > +/* Copies ODP actions from 'in' (with length 'size') to 'out', dropping
> > + * OVS_ACTION_ATTR_OUTPUT along the way. */
> > +static void
> > +prune_output_actions(const struct ofpbuf *in, struct ofpbuf *out)
> 
> Do you think it's worth clarifying that it's 'in->size'?  Otherwise it
> sounds like a separate argument.

Oh, whoops, this was a separate argument in a previous version.

I dropped the parenthetical.

> > +/* Executes all of the datapath actions, except for any OVS_ACTION_ATTR_OUTPUT
> > + * actions, in 'actions' on 'packet', which has the given 'flow', on 'dpif'.
> > + * The actions have slow path reason 'slow' (if any).  Appends any error
> > + * message to 'output'.
> > + *
> > + * This is mainly useful to execute actions to send a packet to an OpenFlow
> > + * controller. */
> 
> Does this now generate NetFlow and sFlow events?  If so, do you think it's worth mentioning here and in the commit message?

It does generate them.  I'll update things.

I decided to make it drop recirc actions too, which can also have side
effects.

> Thanks for fixing this!
> 
> Acked-by: Justin Pettit <jpettit at ovn.org>

Thanks, applied to master.


More information about the dev mailing list