[ovs-dev] [PATCH net-next 4/8] net: core: dev: Add extack argument to dev_change_flags()

David Ahern dsa at cumulusnetworks.com
Wed Dec 5 16:35:48 UTC 2018


On 12/5/18 3:51 AM, Petr Machata wrote:
> In order to pass extack together with NETDEV_PRE_UP notifications, it's
> necessary to route the extack to __dev_open() from diverse (possibly
> indirect) callers. One prominent API through which the notification is
> invoked is dev_change_flags().
> 
> Therefore extend dev_change_flags() with and extra extack argument and
> update all users. Most of the calls end up just encoding NULL, but
> several sites (VLAN, ipvlan, VRF, rtnetlink) do have extack available.
> 
> Since the function declaration line is changed anyway, name the other
> function arguments to placate checkpatch.
> 
> Signed-off-by: Petr Machata <petrm at mellanox.com>
> Acked-by: Jiri Pirko <jiri at mellanox.com>
> Reviewed-by: Ido Schimmel <idosch at mellanox.com>
> ---
>  drivers/infiniband/ulp/ipoib/ipoib_main.c |  6 +++---
>  drivers/net/hyperv/netvsc_drv.c           |  2 +-
>  drivers/net/ipvlan/ipvlan_main.c          | 12 ++++++++----
>  drivers/net/vrf.c                         |  4 ++--
>  include/linux/netdevice.h                 |  3 ++-
>  net/8021q/vlan.c                          |  4 +++-
>  net/core/dev.c                            |  4 +++-
>  net/core/dev_ioctl.c                      |  2 +-
>  net/core/net-sysfs.c                      |  2 +-
>  net/core/rtnetlink.c                      |  3 ++-
>  net/ipv4/devinet.c                        |  2 +-
>  net/ipv4/ipconfig.c                       |  6 +++---
>  net/openvswitch/vport-geneve.c            |  2 +-
>  net/openvswitch/vport-gre.c               |  2 +-
>  net/openvswitch/vport-vxlan.c             |  2 +-
>  15 files changed, 33 insertions(+), 23 deletions(-)
> 

Reviewed-by: David Ahern <dsahern at gmail.com>




More information about the dev mailing list