[ovs-dev] [dpdk-hwol PATCH v1] netdev-dpdk: support port representors

Ophir Munk ophirmu at mellanox.com
Sun Dec 16 12:21:55 UTC 2018


Hi Ian,
Please find comments inline.

> -----Original Message-----
> From: Ian Stokes <ian.stokes at intel.com>
> Sent: Wednesday, December 12, 2018 5:41 PM
> To: Ophir Munk <ophirmu at mellanox.com>; ovs-dev at openvswitch.org
> Cc: Asaf Penso <asafp at mellanox.com>; Shahaf Shuler
> <shahafs at mellanox.com>; Kevin Traynor <ktraynor at redhat.com>; Thomas
> Monjalon <thomas at monjalon.net>; Olga Shern <olgas at mellanox.com>
> Subject: Re: [dpdk-hwol PATCH v1] netdev-dpdk: support port representors
> 
> On 12/11/2018 11:34 PM, Ophir Munk wrote:
> > Dpdk port representors were introduced in dpdk 18.xx.
...
> 
> Thanks for this Ophir.
> 
> I need to complete some more testing on various devices before a full
> review can be completed but here are some first pass comments in the
> mean time that could be addressed for a v2.
> 
> Also with support for 18.11 being upstreamed to master (by tomorrow if
> there are no other comments), will this patch be targeting OVS 2.11? If so
> you could target the v2 at master once 18.11 is there rather than dpdk-hwol
> but I'll leave it to you.
> 

Yes, this patch is targeting OVS 2.11.
All your review comments are accepted. 
I will send v2 on master with updates following your comments.

Regards,
Ophir



More information about the dev mailing list