[ovs-dev] Stopwatch module test failure on FreeBSD.

[Ilya Maximets]

On 18.12.2018 16:40, Ilya Maximets wrote:
> Hi.
> The stopwatch module test constantly fails on FreeBSD.
> It happens in CirrusCI environment and on my local VM.
> Usually FreeBSD failures caused by bash extensions or sed/awk differences,
> but this test looks very suspicious because it based on .c source code.
> 
> Is it a real bug ?
> 

Yes, It's a real bug:
https://mail.openvswitch.org/pipermail/ovs-dev/2018-December/354623.html

Not real, but double, actually. =)

> It'll be good if someone who knows this module will take a look at it.
> 
> Here is the failure log:
> 
> ## ---------------------- ##
> ## Detailed failed tests. ##
> ## ---------------------- ##
> #                             -*- compilation -*-
> 85. library.at:255: testing stopwatch module ...
> ./library.at:256: ovstest test-stopwatch
> Abort trap (core dumped)
> stderr:
> TEST '1-interval-zero-length'
> TEST '1-interval-unit-length'
> TEST '10-intervals-unit-length'
> TEST '10-intervals-linear-growth'
> Assertion '|(&stats)->pctl_95 - (&d->expected_stats)->pctl_95| < 1e-1' failed: |9 - 10| < 0.1
> Assertion failed: (fabs((&stats)->pctl_95 - (&d->expected_stats)->pctl_95) < 1e-1), function test_stopwatch_calculate_stats, file tests/test-stopwatch.c, line 182.
> --- -	2018-12-18 13:24:54.798558000 +0000
> +++ /tmp/cirrus-ci-build/tests/testsuite.dir/at-groups/85/stdout	2018-12-18 13:24:54.797154000 +0000
> @@ -1,2 +1 @@
> -......
> -
> +...
> ./library.at:256: exit code was 134, expected 0
> 85. library.at:255: 85. stopwatch module (library.at:255): FAILED (library.at:256)
> #                             -*- compilation -*-
> ----
> 
> Best regards, Ilya Maximets.
>