[ovs-dev] [PATCH] netdev-linux: Fix function argument order in sfq_tc_load().

Ben Pfaff blp at ovn.org
Wed Dec 19 15:31:26 UTC 2018


sfq_install__() takes quantum before perturb.

Reported-by: shaoke xi <xishaoke.xsk at gmail.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>
---
 lib/netdev-linux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index f86dcd06e563..25d037cb643f 100644
--- a/lib/netdev-linux.c
+++ b/lib/netdev-linux.c
@@ -3798,7 +3798,7 @@ sfq_tc_load(struct netdev *netdev, struct ofpbuf *nlmsg)
     error = tc_parse_qdisc(nlmsg, &kind, &nlattr);
     if (error == 0) {
         sfq = nl_attr_get(nlattr);
-        sfq_install__(netdev, sfq->perturb_period, sfq->quantum);
+        sfq_install__(netdev, sfq->quantum, sfq->perturb_period);
         return 0;
     }
 
-- 
2.16.1



More information about the dev mailing list