[ovs-dev] [PATCH] ofproto-macros.at: Ignore attempts to open '127.0.0.1' as a device.

Ilya Maximets i.maximets at samsung.com
Thu Dec 20 17:31:39 UTC 2018


While configuring sFlow agent OVS tries to treat the value as a name
of the interface at first, after that it tries to treat it as an ip
address. While trying to create netdev from the 'agent', netdev-bsd
calls 'netdev_get_flags()' which produces following warning:

   failed to get flags for network device 127.0.0.1

This does not happen with netdev-linux because it uses its own
implementation of 'get_flags' while creating the netdev.

Let's just ignore the warning for sFlow tests.

Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
---
 tests/ofproto-dpif.at | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at
index 836852b90..ded2ef013 100644
--- a/tests/ofproto-dpif.at
+++ b/tests/ofproto-dpif.at
@@ -6597,7 +6597,7 @@ ovs-vsctl \
 dnl sleep long enough to get the sFlow datagram flushed out (may be delayed for up to 1 second)
 AT_CHECK([ovs-appctl time/warp 2000 100], [0], [ignore])
 AT_CHECK([ovs-appctl revalidator/purge], [0])
-OVS_VSWITCHD_STOP
+OVS_VSWITCHD_STOP(["/failed to get flags for network device 127.0.0.1/d"])
 OVS_APP_EXIT_AND_WAIT([test-sflow])
 AT_CHECK([[sort sflow.log | $EGREP 'LACPCOUNTERS|ERROR' | head -n 1 | sed 's/ /\
         /g']], [0], [dnl
@@ -6687,7 +6687,7 @@ HEADER
         hdr=50-54-00-00-00-0A-50-54-00-00-00-09-08-00-45-01-00-5C-00-00-00-00-80-01-12-8A-0A-0A-0A-02-0A-0A-0A-01-08-00-13-FC-00-00-00-00-00-01-02-03-04-05-06-07-08-09-0A-0B-0C-0D-0E-0F-10-11-12-13-14-15-16-17-18-19-1A-1B-1C-1D-1E-1F-20-21-22-23-24-25-26-27-28-29-2A-2B-2C-2D-2E-2F-30-31-32-33-34-35-36-37-38-39-3A-3B-3C-3D-3E-3F
 ])
 
-OVS_VSWITCHD_STOP
+OVS_VSWITCHD_STOP(["/failed to get flags for network device 127.0.0.1/d"])
 AT_CLEANUP
 
 AT_SETUP([ofproto-dpif - sFlow packet sampling - tunnel push])
@@ -6789,7 +6789,7 @@ HEADER
         hdr=50-54-00-00-00-0A-50-54-00-00-00-05-08-00-45-00-00-5C-00-00-00-00-80-01-B6-4D-C0-A8-01-01-C0-A8-02-02-08-00-13-FC-00-00-00-00-00-01-02-03-04-05-06-07-08-09-0A-0B-0C-0D-0E-0F-10-11-12-13-14-15-16-17-18-19-1A-1B-1C-1D-1E-1F-20-21-22-23-24-25-26-27-28-29-2A-2B-2C-2D-2E-2F-30-31-32-33-34-35-36-37-38-39-3A-3B-3C-3D-3E-3F
 ])
 
-OVS_VSWITCHD_STOP
+OVS_VSWITCHD_STOP(["/failed to get flags for network device 127.0.0.1/d"])
 AT_CLEANUP
 
 AT_SETUP([ofproto-dpif - sFlow packet sampling - MPLS])
@@ -6881,7 +6881,7 @@ HEADER
         hdr=50-54-00-00-00-0A-50-54-00-00-00-09-08-00-45-00-00-14-00-00-00-00-00-00-BA-EB-00-00-00-00-00-00-00-00
 ])
 
-OVS_VSWITCHD_STOP
+OVS_VSWITCHD_STOP(["/failed to get flags for network device 127.0.0.1/d"])
 AT_CLEANUP
 
 
-- 
2.17.1



More information about the dev mailing list