[ovs-dev] [RFC PATCH v2 0/6] Initial support for new SIP Alg.

Tiago Lam tiagolam at gmail.com
Mon Feb 12 23:08:23 UTC 2018


v1 -> v2:
- Addressed comments from v1 (from both Darrell and Mark, thanks!);
- Added support for UDP;
- Added tests for each supported transport, UDP and TCP, and some more
  individual tests for testing particular functions (around parsing and
  framing).

A couple of points worth mentioning in v2:
- Support for TCP framing, in patch 4/6, is not yet optimal as it
  dismisses SIP messages that span across multiple TCP packets. I plan
  to focus on that next;
- Patches 2/6 and 3/6 are independent (can be applied separately of this
  patchset) and provide some flexibility for protocols such as SIP. More
  details in each separate patch.

Regards,

Tiago

Tiago Lam (6):
  Conntrack: Add new API for future SIP Alg.
  Conntrack: Support "out-of-band" expectations.
  Conntrack: Add alg to alg_exp_node struct.
  Conntrack: Add initial support for new SIP Alg.
  Conntrack: Add SIP end-to-end and unit tests.
  Conntrack: Add UDP support for SIP.

 include/openvswitch/ofp-actions.h      |   4 +
 lib/automake.mk                        |   2 +
 lib/conntrack-private.h                |  33 +-
 lib/conntrack-sip.c                    | 959 +++++++++++++++++++++++++++++++++
 lib/conntrack-sip.h                    | 176 ++++++
 lib/conntrack.c                        | 133 +++--
 lib/ofp-parse.c                        |   5 +
 ofproto/ofproto-dpif-xlate.c           |   3 +
 tests/atlocal.in                       |   3 +
 tests/automake.mk                      |   8 +
 tests/conntrack-sip.at                 |   7 +
 tests/sipp/uac_happy_case_scenario.xml | 126 +++++
 tests/sipp/uas_happy_case_scenario.xml | 125 +++++
 tests/system-traffic.at                | 142 +++++
 tests/test-sip.c                       | 485 +++++++++++++++++
 tests/testsuite.at                     |   1 +
 16 files changed, 2157 insertions(+), 55 deletions(-)
 create mode 100644 lib/conntrack-sip.c
 create mode 100644 lib/conntrack-sip.h
 create mode 100644 tests/conntrack-sip.at
 create mode 100644 tests/sipp/uac_happy_case_scenario.xml
 create mode 100644 tests/sipp/uas_happy_case_scenario.xml
 create mode 100644 tests/test-sip.c

-- 
2.14.3



More information about the dev mailing list