[ovs-dev] [PATCH 3/8] datapath: drop unneeded newline

Greg Rose gvrose8192 at gmail.com
Wed Feb 14 23:18:05 UTC 2018


From: Julia Lawall <Julia.Lawall at lip6.fr>

Upstream commit:
    commit e0b10844d9e617a1a5ce2ddf73d38aaa0a47a2a4
    Author: Julia Lawall <Julia.Lawall at lip6.fr>
    Date:   Wed Dec 27 15:51:38 2017 +0100

    openvswitch: drop unneeded newline

    OVS_NLERR prints a newline at the end of the message string, so the
    message string does not need to include a newline explicitly.  Done
    using Coccinelle.

    Signed-off-by: Julia Lawall <Julia.Lawall at lip6.fr>
    Signed-off-by: David S. Miller <davem at davemloft.net>

Cc: Julia Lawall <Julia.Lawall at lip6.fr>
Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
---
 datapath/conntrack.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/datapath/conntrack.c b/datapath/conntrack.c
index a75ae3c..d58240b 100644
--- a/datapath/conntrack.c
+++ b/datapath/conntrack.c
@@ -1315,14 +1315,14 @@ static int parse_nat(const struct nlattr *attr,
 		/* Do not allow flags if no type is given. */
 		if (info->range.flags) {
 			OVS_NLERR(log,
-				  "NAT flags may be given only when NAT range (SRC or DST) is also specified.\n"
+				  "NAT flags may be given only when NAT range (SRC or DST) is also specified."
 				  );
 			return -EINVAL;
 		}
 		info->nat = OVS_CT_NAT;   /* NAT existing connections. */
 	} else if (!info->commit) {
 		OVS_NLERR(log,
-			  "NAT attributes may be specified only when CT COMMIT flag is also specified.\n"
+			  "NAT attributes may be specified only when CT COMMIT flag is also specified."
 			  );
 		return -EINVAL;
 	}
-- 
1.8.3.1



More information about the dev mailing list