[ovs-dev] [PATCH v2] ofproto-dpif-ipfix: Fix an issue in flow key part

Ben Pfaff blp at ovn.org
Thu Feb 15 02:13:34 UTC 2018


On Wed, Feb 14, 2018 at 05:52:07PM -0800, Daniel Benli Ye wrote:
> From: Benli Ye <daniely at vmware.com>
> 
> As struct ipfix_data_record_flow_key_iface didn't calculate
> its length in flow key part, it may cause problem when flow
> key part length is not enough. Use MAX_IF_LEN and MAX_IF_DESCR
> to pre-allocate memory for ipfix_data_record_flow_key_iface.
> 
> v1 -> v2: Use strnlen() to limit the max length.
> 
> Signed-off-by: Daniel Benli Ye <daniely at vmware.com>

Looks good to me.  Thank you!  I'll give Michal a day or so to comment.


More information about the dev mailing list